This revision was automatically updated to reflect the committed changes.
GorNishanov marked an inline comment as done.
Closed by commit rL294933: [coroutines] NFC: Refactor Sema::CoroutineBodyStmt
construction. (authored by GorNishanov).
Changed prior to commit:
GorNishanov marked an inline comment as done.
GorNishanov added a comment.
Preparing to land. Thank you very much for review!
Comment at: lib/Sema/SemaCoroutine.cpp:719
+
+ if (!PromiseRecordDecl)
+return true;
EricWF wrote:
> I figured out what's going
GorNishanov updated this revision to Diff 88152.
GorNishanov added a comment.
Initialized PromiseRecordDecl to nullptr
https://reviews.llvm.org/D28835
Files:
include/clang/AST/StmtCXX.h
include/clang/Sema/ScopeInfo.h
lib/AST/StmtCXX.cpp
lib/Sema/SemaCoroutine.cpp
GorNishanov updated this revision to Diff 88151.
GorNishanov added a comment.
Initialized member variable to zero.
https://reviews.llvm.org/D28835
Files:
include/clang/AST/StmtCXX.h
include/clang/Sema/ScopeInfo.h
lib/AST/StmtCXX.cpp
lib/Sema/SemaCoroutine.cpp
EricWF added a comment.
This LGTM after applying the fixes.
Comment at: lib/Sema/SemaCoroutine.cpp:719
+
+ if (!PromiseRecordDecl)
+return true;
I figured out what's going on. `PromiseRecordDecl` doesn't get initialized to
null when
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
This currently segfaults on my machine. Here is the full output of running
`SemaCXX/coroutines.cpp`.
https://gist.github.com/EricWF/81dc332e21c3e5c6bdc024cda87b846f
I'm not sure
GorNishanov added a comment.
Gentle and melodic ping.
https://reviews.llvm.org/D28835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov added a comment.
LGTM? Pretty please :)
https://reviews.llvm.org/D28835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov marked 2 inline comments as done.
GorNishanov added a comment.
Looks even better now!
https://reviews.llvm.org/D28835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov updated this revision to Diff 85490.
GorNishanov added a comment.
Feedback implemented!
https://reviews.llvm.org/D28835
Files:
include/clang/AST/StmtCXX.h
include/clang/Sema/ScopeInfo.h
lib/AST/StmtCXX.cpp
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index:
GorNishanov updated this revision to Diff 85489.
GorNishanov added a comment.
No changes. Merge with top of the tree (to simplify comparing with the updated
version that is coming up in a second).
https://reviews.llvm.org/D28835
Files:
include/clang/AST/StmtCXX.h
GorNishanov added a comment.
@rsmith, Looking good?
https://reviews.llvm.org/D28835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov created this revision.
Herald added a subscriber: mehdi_amini.
Sema::CheckCompletedCoroutineBody was growing unwieldy with building all of the
substatements. Also, constructors for CoroutineBodyStmt had way too many
parameters.
Instead, CoroutineBodyStmt now defines CtorArgs
13 matches
Mail list logo
