[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2020-01-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Thanks for picking this up!~ Hmm, why did the change in `MallocChecker` tests disappear? > clang is trying to match some strings printed by the ranged constraint manager Are these state dump tests / `exploded-graph-rewriter` tests? We'll need to ignore/silence them in Z3 m

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2020-01-20 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho updated this revision to Diff 239186. mikhail.ramalho added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Two changes: - Moved the BoolAssignmentChecker changes to separate revision (D73062 ). - Rebase

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2020-01-20 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho added a comment. I can give some help here, but my time is quite limited as well :/ Let me at least rebase against master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28955/new/ https://reviews.llvm.org/D28955 ___ cfe-com

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2020-01-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. @ddcc, sure, np! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28955/new/ https://reviews.llvm.org/D28955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2020-01-17 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. I don't have the time to rebase and retest this currently, so it might be better for someone else to take over this patch. Unfortunately, it's been long enough that I don't remember the details of these changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28955/

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2020-01-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a subscriber: mikhail.ramalho. NoQ added a comment. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, szepet, baloghadamsoftware. @mikhail.ramalho brought this up in pr41809 so let's revisit this.

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-09-01 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. @NoQ Does the proposal in https://reviews.llvm.org/D28955#652465 satisfy your concern? https://reviews.llvm.org/D28955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-09-01 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. @dcoughlin No, all three patches are separate. I have been testing them with each applied incrementally onto the previous, with the order trunk, https://reviews.llvm.org/D35450, https://reviews.llvm.org/D28954, then https://reviews.llvm.org/D28955 (this). But since these a

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-09-01 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 113619. ddcc added a comment. Rebase, factor out floating-point changes, fix Z3 type bug, support general APSInt comparison https://reviews.llvm.org/D28955 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h include/clang/StaticAnal

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-08-31 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. @ddcc : When I run this I get a bunch of assertion failures. Does this depend on https://reviews.llvm.org/D28953? (Which was reverted) Is it subsumed by https://reviews.llvm.org/D35450? Is this blocking on a review of another patch on our end? https://reviews.llvm.o

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-05-05 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. @dcoughlin : ping https://reviews.llvm.org/D28955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-03-30 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 93591. ddcc added a comment. Rebase https://reviews.llvm.org/D28955 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h lib/StaticAnalyzer/Checkers/BoolAssignmentChecker

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-01-22 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 85316. ddcc added a comment. Rebase https://reviews.llvm.org/D28955 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h lib/StaticAnalyzer/Checkers/BoolAssignmentChecker

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-01-21 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. > We should have expected-warning on 64-bit targets (where `size_t` easily > overflows `int`) and no-warning on 32-bit targets (where they are of the same > size and the fix for the original issue > https://llvm.org/bugs/show_bug.cgi?id=16558 applies). I think we should ha

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-01-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D28955#652443, @ddcc wrote: > When I was testing this patch, it was on top of both > https://reviews.llvm.org/D28952 and https://reviews.llvm.org/D28953. For > `malloc.c`, the change on line 1708 from `int` to `size_t` is necessary to > prevent

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-01-21 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. When I was testing this patch, it was on top of both https://reviews.llvm.org/D28952 and https://reviews.llvm.org/D28953. For `malloc.c`, the change on line 1708 from `int` to `size_t` is necessary to prevent a false positive warning at line 1710. The other three changes d

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-01-20 Thread Ryan Govostes via Phabricator via cfe-commits
rgov added a comment. Are all the changes here related to the extension/truncation support, for instance the changes to `test/Analysis/malloc.c`? Can you move misc. cleanup changes to another review? https://reviews.llvm.org/D28955 ___ cfe-commits

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-01-20 Thread Dominic Chen via Phabricator via cfe-commits
ddcc created this revision. With the Z3 constraint manager, symbolic extension and truncation of variables can be fully reasoned about. https://reviews.llvm.org/D28955 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h include/clang/StaticAnalyzer/Core/PathSensitive