[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-02-21 Thread Simon Dardis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295728: [mips] Define macros related to -mabicalls in the preprocessor (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D29032?vs=85392=89219#toc Repository: rL LLVM

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-02-15 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added a comment. Ok, I'll have `__mips_abicalls` unconditionally defined for everyone, The other two BSD's will have the traditional macro defined as well. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-02-15 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. No need to preserve the BSD behavior for NetBSD. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-02-15 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added a comment. @joerg ping? https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-26 Thread Ed Maste via Phabricator via cfe-commits
emaste added a comment. > My concern is that the stock gcc distributions for FreeBSD, NetBSD from your > sources doesn't define __mips_abicalls, I think we should consider that a bug in GCC that we'll rectify. If `__mips_abicalls` is used in Linux GCC then we can expect 3rd party sources to

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-24 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. Always defining __mips_abicalls is certainly the saner choice. I'm discussing with the NetBSD/MIPS guys whether we just want to go with it all the time and drop our custom changes for __ABICALLS__. Chances are quite good that we are going in that direction.

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-24 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added a comment. @joerg , @emaste : My concern is that the stock gcc distributions for FreeBSD, NetBSD from your sources doesn't define __mips_abicalls, so I'm worried about potential incompatibilities. Comment at: test/Preprocessor/init.c:4533 +//

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-24 Thread Ed Maste via Phabricator via cfe-commits
emaste added a comment. In https://reviews.llvm.org/D29032#654854, @emaste wrote: > As mentioned in https://reviews.llvm.org/D29032 Err, that should be https://reviews.llvm.org/D29024 https://reviews.llvm.org/D29032 ___ cfe-commits mailing list

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-24 Thread Ed Maste via Phabricator via cfe-commits
emaste added a comment. As mentioned in https://reviews.llvm.org/D29032 I agree with @joerg - `__mips_abicalls` should always be defined if this is what GCC does. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-24 Thread Sean Bruno via Phabricator via cfe-commits
seanbruno accepted this revision. seanbruno added a comment. This revision is now accepted and ready to land. FreeBSD is happy with this. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-23 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. I'm not terribly attached to using __ABICALLS__ for NetBSD, but let me check back with some of the MIPS folks. I would prefer __mips_abicalls to be always defined though, independent of the historic behavior. https://reviews.llvm.org/D29032

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-23 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added a comment. Sending it to the correct list this time. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

2017-01-23 Thread Simon Dardis via Phabricator via cfe-commits
sdardis created this revision. Historically, NetBSD, FreeBSD and OpenBSD have defined the macro ABICALLS in the preprocessor when -mabicalls is in effect. Mainline GCC later defined __mips_abicalls when -mabicalls is in effect. This patch teaches the preprocessor to define these macros when