[PATCH] D29152: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

2017-02-01 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293800: Drop 'dllimport' when redeclaring inline function template without theā€¦ (authored by hans). Changed prior to commit: https://reviews.llvm.org/D29152?vs=85818=86676#toc Repository: rL LLVM

[PATCH] D29152: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

2017-01-30 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D29152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29152: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

2017-01-30 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Ping? https://reviews.llvm.org/D29152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29152: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

2017-01-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a reviewer: rsmith. hans added a comment. +Richard in case you have any theories on why they do it like this. https://reviews.llvm.org/D29152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29152: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

2017-01-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. For non-template `dllimport` functions, MSVC allows providing an inline definition without spelling out the attribute again. In the example below, `f` remains a `dllimport` function. __declspec(dllimport) int f(); inline int f() { return 42; } int useit() {