gtbercea updated this revision to Diff 93676.
gtbercea added a comment.
Move test.
Repository:
rL LLVM
https://reviews.llvm.org/D29644
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/cuda-external-tools.cu
Index: test/Driver/cuda-external-tools.cu
Hahnfeld added a comment.
Just noticed that this isn't specific to OpenMP. Could you move the test to
`Driver/cuda-external-tools.cu` where the rest of `ptxas` is tested?
Repository:
rL LLVM
https://reviews.llvm.org/D29644
___
cfe-commits
gtbercea updated this revision to Diff 93559.
gtbercea added a comment.
Change prefix name in test.
Repository:
rL LLVM
https://reviews.llvm.org/D29644
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
gtbercea updated this revision to Diff 93502.
gtbercea added a comment.
Remove redundant check.
Repository:
rL LLVM
https://reviews.llvm.org/D29644
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload.c:607
+// CHK-VERBOSE: ptxas{{.*}}" "-v"
+// CHK-VERBOSE-NEXT: /bin/cp
This path might not be correct on all systems. Do we really need this check?
Repository:
rL LLVM
gtbercea updated this revision to Diff 93176.
gtbercea added a comment.
Herald added a subscriber: rengolin.
Update patch to reflect latest source code changes.
Repository:
rL LLVM
https://reviews.llvm.org/D29644
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
I'm fine with this.
Repository:
rL LLVM
https://reviews.llvm.org/D29644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
