aaron.ballman added inline comments.
Comment at: lib/Basic/Targets/PPC.h:349
LongLongAlign = 32;
+UseSignedCharForObjCBool = true;
resetDataLayout("E-m:o-p:32:32-f64:32:64-n32");
Do you need to specify this? Isn't it handled by the `TargetInfo`
arphaman updated this revision to Diff 141070.
arphaman added a comment.
Only make the change for the Darwin platforms to avoid ObjC ABI breakage for
non-Darwin platforms.
https://reviews.llvm.org/D29768
Files:
lib/Basic/TargetInfo.cpp
lib/Basic/Targets/AArch64.cpp
arphaman updated this revision to Diff 141045.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Herald added subscribers: jkorous-apple, kbarton, javed.absar, nemanjai.
Sorry, missed the comments last year. Updated.
Repository:
rC Clang
https://reviews.llvm.org/D29768
aaron.ballman added inline comments.
Comment at: lib/Basic/Targets.cpp:4340-4341
llvm::Triple T = llvm::Triple(Triple);
-if (T.isWatchOS())
- UseSignedCharForObjCBool = false;
+if (!T.isWatchOS())
+ UseSignedCharForObjCBool = true;
SizeType =
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D29768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D29768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
The target-specific flag 'UseSignedCharForObjCBool' is used to determine the
type for the Objective-C BOOL type. We should set it to `false` by default so
that new targets can avoid setting it to `true`.
Repository:
rL LLVM
https://reviews.llvm.org/D29768
