This revision was automatically updated to reflect the committed changes.
Closed by commit rL295781: Declare lgamma library builtins as never being const
(authored by jgravelle).
Changed prior to commit:
https://reviews.llvm.org/D29778?vs=88629&id=89287#toc
Repository:
rL LLVM
https://revie
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D29778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
jgravelle-google marked an inline comment as done.
jgravelle-google added a comment.
Thanks, added a comment
https://reviews.llvm.org/D29778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
jgravelle-google updated this revision to Diff 88629.
jgravelle-google added a comment.
- Add comment to lgamma builtins
https://reviews.llvm.org/D29778
Files:
include/clang/Basic/Builtins.def
test/CodeGen/libcall-declarations.c
Index: test/CodeGen/libcall-declarations.c
=
efriedma added inline comments.
Comment at: include/clang/Basic/Builtins.def:1091
+LIBBUILTIN(lgammaf, "ff", "fn", "math.h", ALL_LANGUAGES)
+LIBBUILTIN(lgammal, "LdLd", "fn", "math.h", ALL_LANGUAGES)
Please add a comment explaining why this doesn't have an "e"
jgravelle-google created this revision.
POSIX requires lgamma writes to an external global variable, signgam.
This prevents annotating lgamma with readnone, which is incorrect on
targets that write to signgam.
https://reviews.llvm.org/D29778
Files:
include/clang/Basic/Builtins.def
test/Code
