mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 298597
https://reviews.llvm.org/D30045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@mclow.lists A couple of additional things:
- Add `_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE` to the
`_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES` list in `__config`.
- Add a test for that in
`test/libcxx/depr/enable_removed_cpp17_features.pass.cpp`
Comme
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after fixing inline comments.
Comment at: include/algorithm:3029
+#if _LIBCPP_STD_VER <= 14 ||
defined(_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE)
class _LIBCPP_TYP
mclow.lists created this revision.
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4190 removed
`random_shuffle` from C++1z. (and other stuff)
Wrap all the random_shuffle bits in an #ifdef so they disappear when compiling
with `-std=c++1z` or later.
Introduce a new configuration opti