[PATCH] D30435: [clang-import-test] Lookup inside entities

This revision was automatically updated to reflect the committed changes. Closed by commit rL299976: [clang-import-test] Lookup inside contexts (authored by spyffe). Changed prior to commit: https://reviews.llvm.org/D30435?vs=93929=94875#toc Repository: rL LLVM

[PATCH] D30435: [clang-import-test] Lookup inside entities

a.sidorin accepted this revision. a.sidorin added a comment. Looks excellent now. Thank you Sean! Repository: rL LLVM https://reviews.llvm.org/D30435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe updated this revision to Diff 93929. spyffe added a comment. Added the `ExternalASTMerger` implementation/interface, which I hadn't `svn add`ed before generating the last diff. Repository: rL LLVM https://reviews.llvm.org/D30435 Files: include/clang/AST/ExternalASTMerger.h

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe updated this revision to Diff 93927. spyffe added a comment. Herald added a subscriber: mgorny. • Broke all the `ASTImporter` and `ExternalASTSource` subclassing logic into its own source file, with its API defined in `AST/ExternalASTMerger.h`. • Cleaned up the API for LLDB's consumption:

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe updated this revision to Diff 93721. spyffe added a comment. • Removed namespace qualification of `cast` across the board. • Standardized on `SmallVector` • Factored out the filtering of forward declarations • Fixed a loop as requested. • Made a Origin<> wrapper for arbitrary AST objects

Re: [PATCH] D30435: [clang-import-test] Lookup inside entities

Gosh, I missed the reserve() call. Sorry! I'll be happy to implement this change. Sean > On Mar 6, 2017, at 10:05 AM, Sean Callanan wrote: > > Aleksei, > > thank you for your comments! > > I appreciate your comments in particular about source/destination confusion.

Re: [PATCH] D30435: [clang-import-test] Lookup inside entities

Aleksei, thank you for your comments! I appreciate your comments in particular about source/destination confusion. I can relate to this, as this was (a) an area that confused me while I was working on this code in LLDB; and (b) it was something I had to keep straight in my head even when

[PATCH] D30435: [clang-import-test] Lookup inside entities

a.sidorin added a comment. Hello Sean, It is good to have the ability of recursive lookup. But for me (and I'm sorry), the code becomes very hard to understand: I need to track if the Decl/DC is in the source AST or in the AST being imported, if it was imported or if was in the AST before

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe updated this revision to Diff 89957. spyffe added a comment. • Applied Adrian's suggestion to move comments before the line they apply to. • Got to 100% coverage by changing a test and making an assert for something I couldn't make happen in a test. I did not take Adrian's suggestion to

[PATCH] D30435: [clang-import-test] Lookup inside entities

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. A few stylistic issues inline. It also wouldn't hurt to document what is being tested, either in the clang-import-test sources or in the input files. Otherwise this looks fine. More tests

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe created this revision. Herald added a subscriber: jgosnell. clang-import-test has until now been only able to report top-level entities. This is clearly insufficient; we should be able to look inside structs and namespaces also. This patch adds new test cases for a variety of lookups