[PATCH] D30514: [libc++abi] Update new/delete definitions to match libc++

2017-03-02 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In https://reviews.llvm.org/D30514#690702, @jroelofs wrote: > In https://reviews.llvm.org/D30514#690318, @mehdi_amini wrote: > > > LGTM. > > > > (It seems that having libc++ and libc++abi in the same repo would help > > sharing code like this) > > > I think it would

[PATCH] D30514: [libc++abi] Update new/delete definitions to match libc++

2017-03-02 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs added a comment. In https://reviews.llvm.org/D30514#690318, @mehdi_amini wrote: > LGTM. > > (It seems that having libc++ and libc++abi in the same repo would help > sharing code like this) I think it would be a step backwards in terms of opening things up for layering violations. We

[PATCH] D30514: [libc++abi] Update new/delete definitions to match libc++

2017-03-01 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. (It seems that having libc++ and libc++abi in the same repo would help sharing code like this) https://reviews.llvm.org/D30514