On Mon, Mar 13, 2017 at 10:37:41PM +, Reid Kleckner via Phabricator via
cfe-commits wrote:
> I don't agree. If we want to be good citizens on Linux, what's supposed
> to happen is that we install our shared libraries into
> /usr/lib/${distro_target}, which is what GCC does with its shared
>
pirama updated this revision to Diff 91743.
pirama added a comment.
Update commit message
https://reviews.llvm.org/D30700
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/arch-specific-libdir-rpath.c
test/Driver/arch-specific-libdir.c
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D30700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pirama updated this revision to Diff 91635.
pirama added a comment.
*Actually* add the command line flags.
https://reviews.llvm.org/D30700
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/arch-specific-libdir-rpath.c
rnk added a comment.
In https://reviews.llvm.org/D30700#695358, @Hahnfeld wrote:
> No build system will ever set `-frtlib-add-rpath` to enable this "feature".
> I'm for keeping this opt-out until we have configuration files to set this by
> default. Making it opt-in would weaken its main
pirama updated this revision to Diff 91633.
pirama added a comment.
- Rebase
- Added command line flag and updated tests.
https://reviews.llvm.org/D30700
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/arch-specific-libdir-rpath.c
test/Driver/arch-specific-libdir.c
test/lit.cfg
Hahnfeld added a comment.
No build system will ever set `-frtlib-add-rpath` to enable this "feature". I'm
for keeping this opt-out until we have configuration files to set this by
default. Making it opt-in would weaken its main reason of existence: Not to
break simple binaries for the user,
rnk added a comment.
Both suggestions sound good to me. Thanks!
https://reviews.llvm.org/D30700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pirama added a comment.
In https://reviews.llvm.org/D30700#694511, @rnk wrote:
> I was thinking `-f[no-]compiler-rt-rpath` or something, but openmp is not
> part of compiler-rt. Name recommendations welcome. \
Maybe `-f[no-]rtlib-add-rpath`?
> We might also want to reconsider the default
rnk added a comment.
Can you add a flag pair to control the insertion of rpath into the final
binary? As things are currently, clang is basically leaking paths from the
machine doing the linking into the final binary, which often will not run on
the same machine. I was thinking
pirama created this revision.
This patch unconditionally adds -rpath of the arch-specific subdirectory
in resource directory (instead of doing so only during native
compilation).
This patch also re-enables test arch-specific-libdir.c which was
silently unsupported because of the REQUIRES tag
11 matches
Mail list logo
