fpetrogalli added a comment.
Alexey,
thank you for reviewing this. If you don't mind, I will wait applying the
changes you requested, Unfortunately I am not ready yet to send out an update
as I am still working on the vector ABI. I will ping you when ready.
Francesco
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6818-6819
+ISAData);
+}
+if (CGM.getTriple().getArch() == llvm::Triple::aarch64) {
+ ISADataTy ISAData[] = {
else if
fpetrogalli planned changes to this revision.
fpetrogalli added a comment.
Dear all,
thank you for reviewing this patch. We found out an error in the spec and would
like to fix it before things are used.
I will soon update this patch.
Thanks,
Francesco
https://reviews.llvm.org/D30739
ABataev added a comment.
Guys, sorry for the delay with the reviews. I was on a vacation, now I'm on a
relocation process. Will look at all patches as soon as possible, but not
earlier than next week :( Sorry again.
https://reviews.llvm.org/D30739
fpetrogalli added a comment.
Thanks, I do not have commit rights, can anyone commit this?
https://reviews.llvm.org/D30739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D30739#706304, @fpetrogalli wrote:
> AFAIK, none of the machinery required in LLVM to expose the mangled names in
> the vectorizer is present in trunk. There
fpetrogalli added a comment.
In https://reviews.llvm.org/D30739#706292, @Hahnfeld wrote:
> In principal looks good to me although I'm not really familiar with this
> part. Does that work for you if you have the `declare simd` in a header file
> and the implementation in another file? On x86_64
Hahnfeld added a comment.
In principal looks good to me although I'm not really familiar with this part.
Does that work for you if you have the `declare simd` in a header file and the
implementation in another file? On x86_64 I currently get:
remark: loop not vectorized: call instruction
rengolin added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6821
+ ISADataTy ISAData[] = {
+ {'n', 64}, // double-word Advanced SIMD
+ {'n', 128}, // quad-word Advanced SIMD
fpetrogalli wrote:
> rengolin wrote:
> > No f32?
fpetrogalli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6821
+ ISADataTy ISAData[] = {
+ {'n', 64}, // double-word Advanced SIMD
+ {'n', 128}, // quad-word Advanced SIMD
rengolin wrote:
> No f32?
Sorry, I am not
rengolin added reviewers: Hahnfeld, carlo.bertolli, arpith-jacob.
rengolin added a comment.
Looks ok to me, but I'm not very knowledgeable in that area. Hopefully some
OpenMP Clang developers I added could give you a more concrete approval. :)
Comment at:
fpetrogalli added a comment.
Gentle ping.
Thanks,
Francesco
https://reviews.llvm.org/D30739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fpetrogalli updated this revision to Diff 91035.
fpetrogalli marked an inline comment as done.
fpetrogalli added a comment.
Changes:
- fixed formatting;
- added two tests that were missing.
https://reviews.llvm.org/D30739
Files:
lib/Basic/Targets.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
fhahn added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6664
+
+ static void
+ emitTargetDeclareSimdFunction(const FunctionDecl *FD, llvm::Function *Fn,
Shouldn't this indentation be on the same level as namespace{}?
fpetrogalli created this revision.
Herald added subscribers: rengolin, aemerson.
This patch enables the code generation of vector function names that are
described by attaching a "#pragma omp declare simd" directive to the
scalar function definition/declaration, for the Advanced SIMD (NEON)
15 matches
Mail list logo
