[PATCH] D31078: [libunwind] Clean up macro usage.

2017-03-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299225: [libunwind] Clean up macro usage. (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D31078?vs=93646=93647#toc Repository: rL LLVM https://reviews.llvm.org/D31078

[PATCH] D31078: [libunwind] Clean up macro usage.

2017-03-31 Thread Ranjeet Singh via Phabricator via cfe-commits
rs updated this revision to Diff 93646. rs marked 6 inline comments as done. https://reviews.llvm.org/D31078 Files: include/__libunwind_config.h include/libunwind.h include/unwind.h src/AddressSpace.hpp src/Unwind-EHABI.cpp src/Unwind-EHABI.h src/Unwind-sjlj.c

[PATCH] D31078: [libunwind] Clean up macro usage.

2017-03-27 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus the suggested cleanup. Comment at: include/__libunwind_config.h:15 !defined(__ARM_DWARF_EH__) #define _LIBUNWIND_ARM_EHABI 1 #endif This

[PATCH] D31078: [libunwind] Clean up macro usage.

2017-03-17 Thread Ranjeet Singh via Phabricator via cfe-commits
rs created this revision. Convention in libunwind is to use !defined(FOO) not !FOO. https://reviews.llvm.org/D31078 Files: include/__libunwind_config.h include/libunwind.h include/unwind.h src/AddressSpace.hpp src/Unwind-EHABI.cpp src/Unwind-EHABI.h src/Unwind-sjlj.c