This revision was automatically updated to reflect the committed changes.
Closed by commit rL298696: [clangd] Add support for vscode extension
configuration (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31121?vs=92367&id=92907#toc
Repository:
rL LLVM
https://rev
stanionascu added a comment.
Thanks for review!
Would be great if somebody would commit it, as I cannot do it myself.
https://reviews.llvm.org/D31121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Sorry for the delay.
https://reviews.llvm.org/D31121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
stanionascu added inline comments.
Comment at: clangd/clients/clangd-vscode/package.json:45
+"default": "clangd",
+"description": "The path to clangd executable"
+},
krasimir wrote:
> krasimir wrote:
> > May
stanionascu updated this revision to Diff 92367.
stanionascu edited the summary of this revision.
stanionascu added a comment.
- removed unrelated new line change
- extended the "clang.path" description a bit
- removed defaultValue for getConfig<>, as it's anyway "contributed" by
extension packag
krasimir added a comment.
It looks pretty good! I just have a minor suggestion.
Comment at: clangd/clients/clangd-vscode/package.json:45
+"default": "clangd",
+"description": "The path to clangd executable"
+},
---
krasimir added inline comments.
Comment at: clangd/clients/clangd-vscode/package.json:45
+"default": "clangd",
+"description": "The path to clangd executable"
+},
Maybe prepend a `, for example: /usr/bin/cla
