[PATCH] D31378: [PCH] Attach instance's dependency collectors to PCH external AST sources.

2017-03-29 Thread Graydon Hoare via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299009: [PCH] Attach instance's dependency collectors to PCH external AST sources. (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D31378?vs=93089=93387#toc Repository: rL

[PATCH] D31378: [PCH] Attach instance's dependency collectors to PCH external AST sources.

2017-03-29 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. Thanks for working on this! LGTM too https://reviews.llvm.org/D31378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31378: [PCH] Attach instance's dependency collectors to PCH external AST sources.

2017-03-29 Thread Doug Gregor via Phabricator via cfe-commits
doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D31378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31378: [PCH] Attach instance's dependency collectors to PCH external AST sources.

2017-03-26 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. When a PCH is included via -include-pch, clang should treat the current TU as dependent on the sourcefile that the PCH was generated from. This is currently _partly_ accomplished by InitializePreprocessor calling AddImplicitIncludePCH to synthesize an implicit