EricWF added a comment.
Woops. this patch also needed changes to `TreeTransform.h`. I'll add those
tonight.
Repository:
rL LLVM
https://reviews.llvm.org/D31399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
alekseyshl added a comment.
Seems like this bot is not happy about this change:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3771
Repository:
rL LLVM
https://reviews.llvm.org/D31399
___
cfe-commits mailing list
cfe-commit
This revision was automatically updated to reflect the committed changes.
GorNishanov marked an inline comment as done.
Closed by commit rL298891: [coroutines] Handle
get_return_object_on_allocation_failure (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D31399?vs=9
GorNishanov updated this revision to Diff 93177.
GorNishanov added a comment.
Added diagnostic test to SemaCXX/coroutines.cpp
Preparing to Land
https://reviews.llvm.org/D31399
Files:
include/clang/AST/StmtCXX.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/StmtCXX.cpp
lib/CodeGen/C
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This LGTM minus inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:793
+ LookupResult Found(S, DN, Loc, Sema::LookupMemberName);
+ // Suppress diagnostics when a priva
GorNishanov created this revision.
Herald added a subscriber: mehdi_amini.
If promise_type has get_return_object_on_allocation_failure defined,
check if an allocation function returns nullptr, and if so,
return the result of get_return_object_on_allocation_failure().
https://reviews.llvm.org/D3
