[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

2017-04-06 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299700: [clang-tidy] Reuse FileID in getLocation (authored by chh). Repository: rL LLVM https://reviews.llvm.org/D31406 Files: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp Index: clang-tools-e

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

2017-03-31 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh reopened this revision. chh added a comment. This revision is now accepted and ready to land. This was reverted due to one failed test case clang-tidy/llvm-include-order.cpp on Windows: Assertion failed: EndColNo <= map.getSourceLine().size() && "Invalid range!", file C:\Buildbot\Slave\llv

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

2017-03-30 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299119: [clang-tidy] Reuse FileID in getLocation (authored by chh). Changed prior to commit: https://reviews.llvm.org/D31406?vs=93499&id=93554#toc Repository: rL LLVM https://reviews.llvm.org/D31406

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

2017-03-30 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Do you have commit rights? https://reviews.llvm.org/D31406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

2017-03-30 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 93499. chh marked an inline comment as done. chh added a comment. Use getOrCreateFileID. https://reviews.llvm.org/D31406 Files: clang-tidy/ClangTidy.cpp Index: clang-tidy/ClangTidy.cpp === ---

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

2017-03-30 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thank you for finding out the root cause here! Comment at: clang-tidy/ClangTidy.cpp:241 -const FileEntry *File = SourceMgr.getFileManager().getFile(FilePath);