szepet added a comment.
Hello Artem!
Could you please commit these changes? (And https://reviews.llvm.org/D31541 as
well.) Thanks in advance!
https://reviews.llvm.org/D31538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
xazax.hun accepted this revision.
xazax.hun added a comment.
I think there was only one comment but that is already addressed in a dependent
revision. So I think this one is good as is.
https://reviews.llvm.org/D31538
___
cfe-commits mailing list
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315301: [analyzer] MisusedMovedObject: Fix state-resetting a
base-class sub-object. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D31538?vs=93652&id=118351#toc
Repository:
NoQ created this revision.
If a state reset method is defined in a parent class, but called over an object
of a child class, then the checker doesn't treat this as a state reset, at
least for the sake of "Copying a 'moved-from' object" warning class.
The patch fixes it, but Peter may have a bet
szepet added a comment.
Thank you for working on that, Artem!
The changes look good, just one comment about that suspicious remove.
Comment at: lib/StaticAnalyzer/Checkers/MisusedMovedObjectChecker.cpp:426
+
+State = State->remove(WholeObjectRegion);
C.addTransition(St
szepet added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MisusedMovedObjectChecker.cpp:426
+
+State = State->remove(WholeObjectRegion);
C.addTransition(State);
szepet wrote:
> I am wondering if I made a mistake but I think this should be
>
szepet accepted this revision.
szepet added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/StaticAnalyzer/Checkers/MisusedMovedObjectChecker.cpp:426
+
+State = State->remove(WholeObjectRegion);
C.addTransition(State);
s
