[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 95511. EricWF added a comment. - Update so it merges against master. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp test/SemaCXX/coroutines.cpp

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF reopened this revision. EricWF added a comment. This revision is now accepted and ready to land. Re-opening since the last commit had to be reverted. https://reviews.llvm.org/D31562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 95382. EricWF marked an inline comment as done. EricWF added a comment. - Fix `MaybeODRUseExprs` assertion. - Remove mistakenly present `CoroutineBuilder.h` file. I'll land this later today if there are no objections. https://reviews.llvm.org/D31562 Files:

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF marked an inline comment as done. EricWF added inline comments. Comment at: lib/Sema/CoroutineBuilder.h:1 +//===- CoroutineBuilder.h - Coroutine Semantic checking -*- C++ -*-===// +// GorNishanov wrote: > This file is called: > >

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-13 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added inline comments. Comment at: lib/Sema/CoroutineBuilder.h:1 +//===- CoroutineBuilder.h - Coroutine Semantic checking -*- C++ -*-===// +// This file is called: CoroutineStmtBuilder.h in trunk Comment at:

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-12 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:680 + // likely due to the scope at in which this function is called. + auto *VD = Result.getAsSingle(); + if (!VD) { @rsmith is this the correct way to build a `DeclRefExpr` to an existing

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-12 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 95074. EricWF added a comment. This revision is now accepted and ready to land. - Add call to `MarkDeclRefReferenced` even though it doesn't prevent the assertion. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-03 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF planned changes to this revision. EricWF added a comment. This patch currently triggers an assertion in `SemaDecl.cpp:12290` `assert(MaybeODRUseExprs.empty() && "Leftover expressions for odr-use checking");` I'll have to come up with a fix for that before this is committed.

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-03 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93939. EricWF added a comment. - Merge with master - Fix `coro-alloc.cpp` test so that it declares new. - Add FIXME comment regarding assertion about an MaybeODRUsedExpr that hasn't been correctly handled. (the VarDecl for `std::nothrow` is broken).

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-01 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-01 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93742. EricWF added a comment. - Actually remove incorrectly added changes. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutines.cpp Index: test/SemaCXX/coroutines.cpp

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93739. EricWF added a comment. - Remove incorrectly added changes. Note that this patch is built on top of https://reviews.llvm.org/D31487 and not trunk. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93737. EricWF added a comment. - general cleanup. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutines.cpp Index: test/SemaCXX/coroutines.cpp