Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D31594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
yaxunl added a comment.
LGTM. Thanks.
https://reviews.llvm.org/D31594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echuraev updated this revision to Diff 94032.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D31594
Files:
lib/Sema/SemaInit.cpp
test/CodeGenOpenCL/sampler.cl
test/SemaOpenCL/sampler_t.cl
Index: test/SemaOpenCL/sampler_t.cl
Anastasia added inline comments.
Comment at: test/SemaOpenCL/sampler_t.cl:68
foo(argsmp);
- foo(5); // expected-error{{sampler_t variable required - got 'int'}}
+ foo(CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE |
CLK_FILTER_LINEAR);
sampler_t sa[] = {argsmp, c
yaxunl added a comment.
I am not sure if this is going to work. At least you need to add a codegen test
for this new usage.
https://reviews.llvm.org/D31594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
echuraev created this revision.
Herald added a subscriber: yaxunl.
https://reviews.llvm.org/D31594
Files:
lib/Sema/SemaInit.cpp
test/SemaOpenCL/sampler_t.cl
Index: test/SemaOpenCL/sampler_t.cl
===
--- test/SemaOpenCL/sampler_t.
