This revision was automatically updated to reflect the committed changes.
Closed by commit rL299641: [Sema] Extend GetSignedVectorType to deal with non
ExtVector types (authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D31667?vs=94205=94344#toc
Repository:
rL LLVM
sdardis marked an inline comment as done.
sdardis added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:9736
+ }
+
+ if (TypeSize == Context.getTypeSize(Context.LongLongTy))
ahatanak wrote:
> This isn't particularly urgent, but can we use ASTContext
>
ahatanak added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:9736
+ }
+
+ if (TypeSize == Context.getTypeSize(Context.LongLongTy))
This isn't particularly urgent, but can we use ASTContext
::getIntTypeForBitwidth here rather than calling getVectorType or
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks Simon! LGTM
https://reviews.llvm.org/D31667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sdardis updated this revision to Diff 94205.
sdardis marked 5 inline comments as done.
sdardis added a comment.
Addressed review comments, added more tests.
https://reviews.llvm.org/D31667
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-ops.c
Index: test/Sema/vector-ops.c
bruno added a comment.
Great! Thanks for improving this.
Comment at: include/clang/Sema/Sema.h:9287
bool AllowBothBool, bool AllowBoolConversion);
- QualType GetSignedVectorType(QualType V);
+ QualType GetSignedVectorType(QualType V, bool
sdardis created this revision.
This improves some error messages which would otherwise refer to
ext_vector_type types in contexts where there are no such types.
Factored out from https://reviews.llvm.org/D25866 at reviewer's request.
https://reviews.llvm.org/D31667
Files:
