[PATCH] D31739: Add markup for libc++ dylib availability

ldionne added inline comments. Comment at: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/lit.local.cfg:1 +if 'availability' in config.available_features: +config.unsupported = True mehdi_amini wrote: > thakis wrote: > > Did you mea

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini marked an inline comment as done. mehdi_amini added subscribers: ldionne, Bigcheese. mehdi_amini added inline comments. Comment at: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/lit.local.cfg:1 +if 'availability' in config.available_feature

[PATCH] D31739: Add markup for libc++ dylib availability

thakis added inline comments. Herald added subscribers: llvm-commits, jdoerfert, jfb, christof. Herald added a reviewer: serge-sans-paille. Herald added a project: LLVM. Comment at: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/lit.local.cfg:1 +if 'ava

[PATCH] D31739: Add markup for libc++ dylib availability

bcain added a comment. I think some of the `XFAIL: availability` may be wrong here. I'd submit a patch, but it's not clear to me what the appropriate fix is. Comment at: libcxx/trunk/utils/libcxx/test/config.py:400 +if self.use_system_cxx_lib or self.with_availability

[PATCH] D31739: Add markup for libc++ dylib availability

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM, and it's liable to bitrot if it hangs out here any longer. We can always iterate in tree if we find a better way to organize the markup and/or tests. Eric and Marshall: do

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini added a comment. @mclow.lists you mentioned on IRC you may have some suggestions to make this less noisy? Do you still plan to review? https://reviews.llvm.org/D31739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini added a comment. @mclow.lists you mentioned on IRC you may have some suggestions to make this less noisy? Do you still plan to review? https://reviews.llvm.org/D31739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D31739: Add markup for libc++ dylib availability

jroelofs added inline comments. Comment at: utils/libcxx/test/config.py:387 +self.config.available_features.add( +'with_system_cxx_lib=%s' % component) mehdi_amini wrote: > jroelofs wrote: > > Is it worth filtering out `none`

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini marked 5 inline comments as done. mehdi_amini added inline comments. Comment at: utils/libcxx/test/config.py:289 +def configure_availability(self): +# FIXME doc +self.with_availability = self.get_lit_bool('with_availability', False) ---

[PATCH] D31739: Add markup for libc++ dylib availability

arphaman added inline comments. Comment at: include/__config:1160 + +#endif // _LIBCPP_CONFIG Redundant whitespace added? Comment at: utils/libcxx/test/config.py:358 +def add_deployement_feature(self, feature): +(arch, name, vers

[PATCH] D31739: Add markup for libc++ dylib availability

jroelofs added inline comments. Comment at: utils/libcxx/test/config.py:289 +def configure_availability(self): +# FIXME doc +self.with_availability = self.get_lit_bool('with_availability', False) Can you expand on what the FIXME here wants? Is

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini added a comment. Ping? https://reviews.llvm.org/D31739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits