This revision was automatically updated to reflect the committed changes.
Closed by commit rL302513: [X86] Clang option -fuse-init-array has no effect
when generating for MCU target (authored by n.bozhenov).
Changed prior to commit:
https://reviews.llvm.org/D32543?vs=97866=98262#toc
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AndreiGrischenko updated this revision to Diff 97866.
AndreiGrischenko added a comment.
Thanks Craig for the good advice. You are right I can check llc with MCU triple
using option -use-ctors. Please see updated patch.
https://reviews.llvm.org/D32543
Files:
craig.topper added a comment.
It looksl ike UseInitArray is connected to -use-ctors command line option to
llc so we should be able to test this without a frontend test.
https://reviews.llvm.org/D32543
___
cfe-commits mailing list
craig.topper added a comment.
Should we add a test to test/CodeGen/X86/constructor.ll that test appears to
have been modified when NAcl was added to the line you changed.
https://reviews.llvm.org/D32543
___
cfe-commits mailing list
AndreiGrischenko added a comment.
In https://reviews.llvm.org/D32543#738595, @ahatanak wrote:
> Do you need a front-end test? Since the changes are in the backend, I think
> it's better to add the test to the backend (using llc).
Yes, changes are in the backend, but they fix interface between
ahatanak added a comment.
Do you need a front-end test? Since the changes are in the backend, I think
it's better to add the test to the backend (using llc).
https://reviews.llvm.org/D32543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AndreiGrischenko created this revision.
Our runtime for MCU X86 target supports .init_array section for globals that
should be dynamically initialized.
But default Clang generates .ctors section and even if it has option
-fuse-init-array, the option has no effect if set explicitly in a
