mgorny requested changes to this revision.
mgorny added a comment.
This revision now requires changes to proceed.
Could you please rebase? I'm pretty sure this breaks our use but I can't test
since it no longer applies cleanly.
https://reviews.llvm.org/D32595
chapuni added a comment.
I don't think this would be ready to land.
https://reviews.llvm.org/D32595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Ah. I see what you're saying. I was thinking of the mismatch in a different
way, but your solution makes sense. LGTM.
https://reviews.llvm.org/D32595
tstellar added a comment.
In https://reviews.llvm.org/D32595#769044, @beanz wrote:
> Is this really something we should be supporting? Building and testing clang
> with potentially out-of-sync lit or gtest seems undesirable to me.
This is actually what this patch is trying to avoid. For
mgorny added a comment.
(note that I don't mind removing the llvm-config bit for it; but we need the
cache variable to stay)
https://reviews.llvm.org/D32595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny added a comment.
This is going to break Gentoo. We're relying on the ability to specify
LLVM_MAIN_SRC_DIR to provide unpacked LLVM sources with gtest. Without that, I
don't see how we can use tests.
https://reviews.llvm.org/D32595
___
beanz added a comment.
Is this really something we should be supporting? Building and testing clang
with potentially out-of-sync lit or gtest seems undesirable to me.
It is worth noting that we do have mods to gtest, so supporting any standard
distribution of it seems like a not great idea.
tstellar added a comment.
In https://reviews.llvm.org/D32595#740222, @chapuni wrote:
> Let me know steps for testing that you suppose.
> I guess;
>
> - Use installed version of lit via virtualenv.
Not necessarily via virtualenv, either by installing the lit pypi package or
using a distro
chapuni added a comment.
Let me know steps for testing that you suppose.
I guess;
- Use installed version of lit via virtualenv.
- Use out-of-tree version of gtest.
- Use another build tree to use FileCheck
I know the clause CLANG_BUILT_STANDALONE would be made simpler if we could
abandon
tstellar created this revision.
clang was using LLVM_MAIN_SRC_DIR to search for lit.py to use for
running clang's lit tests. This was dangerous though, because
LLVM_MAIN_SRC_DIR was determined by using llvm-config --src-root
and this directory may have been modified since llvm-config was
built
10 matches
Mail list logo
