[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308020: [clang-tidy] Add bugprone-suspicious-memset-usage check (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D32700?vs=106620&id=106624#toc Repository: rL LLVM https://revi

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

rnkovacs updated this revision to Diff 106620. rnkovacs marked an inline comment as done. rnkovacs added a comment. Moved comments inside `if` bodies. https://reviews.llvm.org/D32700 Files: clang-tidy/CMakeLists.txt clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

whisperity added inline comments. Comment at: clang-tidy/bugprone/SuspiciousMemsetUsageCheck.cpp:57-58 +void SuspiciousMemsetUsageCheck::check(const MatchFinder::MatchResult &Result) { + // Case 1: fill_char of memset() is a character '0'. Probably an integer zero + // was int

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a single comment. Thank you for working on this! Comment at: clang-tidy/bugprone/SuspiciousMemsetUsageCheck.cpp:74-75 + + // Case 2: fill_char of memset() i

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

rnkovacs marked an inline comment as done. rnkovacs added inline comments. Comment at: docs/clang-tidy/checks/bugprone-suspicious-memset-usage.rst:10 + +**Case 1: Fill value is a character '0'** + whisperity wrote: > Shouldn't this `'0'` be enclosed within backti

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

rnkovacs updated this revision to Diff 106381. https://reviews.llvm.org/D32700 Files: clang-tidy/CMakeLists.txt clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/SuspiciousMemsetUsageCheck.cpp clang-tidy/bugprone/SuspiciousMemsetUsageCheck

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

whisperity resigned from this revision. whisperity added inline comments. Comment at: docs/clang-tidy/checks/bugprone-suspicious-memset-usage.rst:10 + +**Case 1: Fill value is a character '0'** + Shouldn't this `'0'` be enclosed within backticks? https://review

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

rnkovacs updated this revision to Diff 106268. rnkovacs added a comment. Herald added a subscriber: baloghadamsoftware. - Added `char[]` exception along with a test case. There are no more false positives on LLVM. - Simplified fix-its by using `clang::tooling::fixit` functions. https://reviews.

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

alexfh added inline comments. Comment at: clang-tidy/bugprone/SuspiciousMemsetUsageCheck.cpp:127-130 +SourceRange LHSRange = FillChar->getSourceRange(); +SourceRange RHSRange = ByteCount->getSourceRange(); +StringRef RHSString = getAsString(Result, RHSRange); +Str

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed. Considering the results published in the opening description: /home/reka/codechecker_dev_env/llvm/lib/Support/NativeFormatting.cpp:55:29:

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

rnkovacs updated this revision to Diff 106172. rnkovacs retitled this revision from "[clang-tidy] Add misc-suspicious-memset-usage check." to "[clang-tidy] Add bugprone-suspicious-memset-usage check.". rnkovacs edited the summary of this revision. rnkovacs added a comment. - Created new module `