djasper closed this revision.
djasper added a comment.
Renamed Tok to RecordTok to avoid the nested scope and submitted as r305667.
https://reviews.llvm.org/D32825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jtbandes marked an inline comment as done.
jtbandes added a comment.
Another ping.
https://reviews.llvm.org/D32825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jtbandes updated this revision to Diff 98593.
jtbandes added a comment.
Update from review
https://reviews.llvm.org/D32825
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
jtbandes marked an inline comment as done.
jtbandes added inline comments.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:368
// We don't merge short records.
- if (Line.First->isOneOf(tok::kw_class, tok::kw_union, tok::kw_struct,
-
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
One nit, otherwise looks good.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:368
// We don't merge short records.
- if (Line.First->isOneOf(tok::kw_class,
jtbandes added a comment.
Ping :)
https://reviews.llvm.org/D32825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jtbandes added a comment.
It strikes me that this doesn't handle `using`-style type aliases, but it seems
hard to do this correctly in general, so still valuable to catch this simple,
common case. Let me know if you have any better suggestions!
https://reviews.llvm.org/D32825
jtbandes created this revision.
Herald added a subscriber: klimek.
Fixes an issue where `struct A { int X; };` would be broken onto multiple
lines, but `typedef struct A { int X; } A2;` was collapsed onto a single line.
https://reviews.llvm.org/D32825
Files:
