NoQ added inline comments.
Herald added subscribers: a.sidorin, rnkovacs, szepet.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:340-358
+const auto *Templ = Func->getPrimaryTemplate();
+if (!Templ)
+ return;
+
+const auto *TParams = Templ->getTempla
baloghadamsoftware updated this revision to Diff 153314.
baloghadamsoftware added a comment.
Herald added a reviewer: george.karpenkov.
Herald added a subscriber: mikhail.ramalho.
Rebased to https://reviews.llvm.org/rL335835.
https://reviews.llvm.org/D32845
Files:
include/clang/StaticAnalyzer
baloghadamsoftware updated this revision to Diff 153481.
baloghadamsoftware added a comment.
Previous rebase was wrong, this is the correct one.
https://reviews.llvm.org/D32845
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/An
whisperity added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:317
+def MismatchedIteratorChecker : Checker<"MismatchedIterator">,
+ HelpText<"Check for use of iterators of different containers where iterators
of the same container are expecte
baloghadamsoftware updated this revision to Diff 129871.
baloghadamsoftware added a comment.
Rebased to current Part 3. Comment added.
https://reviews.llvm.org/D32845
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/Inp
a.sidorin added a comment.
Hello Adam,
This looks like a nice improvement. I have some remarks inline.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:382
}
+ } else if (!isa(&Call)) {
+// The main purpose of iterators is to abstract away from different
--
baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:382
}
+ } else if (!isa(&Call)) {
+// The main purpose of iterators is to abstract away from different
baloghadamsoftware updated this revision to Diff 130174.
baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added a comment.
Updated according to some comments.
https://reviews.llvm.org/D32845
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/C
This revision was automatically updated to reflect the committed changes.
baloghadamsoftware marked an inline comment as done.
Closed by commit rC341790: [Analyzer] Iterator Checker - Part 4: Mismatched
iterator checker for function… (authored by baloghadamsoftware, committed by ).
Changed prior
baloghadamsoftware updated this revision to Diff 163517.
baloghadamsoftware removed a reviewer: george.karpenkov.
baloghadamsoftware added a comment.
Herald added a reviewer: george.karpenkov.
Since https://reviews.llvm.org/rL338263 fixed a bug in the cleanup phase the
tests for mismatched iterat
baloghadamsoftware updated this revision to Diff 163671.
baloghadamsoftware added a comment.
Minor changes.
https://reviews.llvm.org/D32845
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/Inputs/system-header-simulator
baloghadamsoftware marked 3 inline comments as done.
baloghadamsoftware added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:317
+def MismatchedIteratorChecker : Checker<"MismatchedIterator">,
+ HelpText<"Check for use of iterators of different
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:388
+// template parameters for different containers. So we can safely
+// assume that passing iterators of different containers as arguments
+// whose type replaces
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: Szelethus.
Looks good. I guess we may have to tone down the heuristic about "all template
functions" if we see it fail.
@a.sidorin and @whisperity have some valid minor co
14 matches
Mail list logo
