[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

This revision was automatically updated to reflect the committed changes. Closed by commit rC341791: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers (authored by baloghadamsoftware, committed by ). Changed prior to commit:

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 163725. baloghadamsoftware added a comment. ) added. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index: test/Analysis/mismatched-iterator.cpp

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 163724. baloghadamsoftware added a comment. Comments added, functions renamed. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index:

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Szelethus. I think this patch is in good shape. In https://reviews.llvm.org/D32859#1187551, @baloghadamsoftware wrote: > I do not see which lines exactly you commented

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware added a comment. In https://reviews.llvm.org/D32859##inline-360206, @NoQ wrote: > I do not immediately understand what is this useful for. At least tests don't > look like they make use of these offset manipulations(?) > > Without full understanding, i wonder: when we

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1061 + // first reassign all iterator positions to the new container which + // are not past the container (thus not greater or equal to the + // current

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 153482. baloghadamsoftware added a comment. Herald added a subscriber: mikhail.ramalho. Rebased to https://reviews.llvm.org/rL335835. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 144106. baloghadamsoftware added a comment. Herald added a reviewer: george.karpenkov. One test failed after rebased to the current master branch. Depending on the internal implementation of the iterator and the move operation of the container it

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 130185. baloghadamsoftware added a comment. Rebased. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index: test/Analysis/mismatched-iterator.cpp

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 129960. baloghadamsoftware added a comment. Rebased to current part 4. New tests added. Comments added. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index:

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

NoQ added inline comments. Herald added subscribers: a.sidorin, rnkovacs, szepet. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1489-1511 +SymbolRef replaceSymbol(SymbolManager , SymbolRef OrigExpr, +SymbolRef OldExpr, SymbolRef NewSym) { +

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware created this revision. If a container is moved by its move assignment operator, according to the standard all their iterators except the past-end iterators remain valid but refer to the new container. This patch introduces support for this case in the iterator checkers.