This revision was automatically updated to reflect the committed changes.
CaseyCarter marked an inline comment as done.
Closed by commit rL303889: [test] Remove workaround for C1XX
conversion-to-nullptr bug (authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D33290?vs=9
EricWF added a comment.
@CaseyCarter Changes like this are good for post-commit review (ie just commit
it)
https://reviews.llvm.org/D33290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D33290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
CaseyCarter marked an inline comment as done.
CaseyCarter added inline comments.
Comment at: test/support/test_workarounds.h:21
#if defined(TEST_COMPILER_C1XX)
-# define TEST_WORKAROUND_C1XX_BROKEN_NULLPTR_CONVERSION_OPERATOR
-# define TEST_WORKAROUND_C1XX_BROKEN_IS_TRIVIALLY_CO
CaseyCarter updated this revision to Diff 99336.
CaseyCarter added a comment.
Commit the change to the affected test code as well.
https://reviews.llvm.org/D33290
Files:
test/support/poisoned_hash_helper.hpp
test/support/test.workarounds/c1xx_broken_nullptr_conversion_operator.pass.cpp
te
STL_MSFT added inline comments.
Comment at: test/support/test_workarounds.h:21
#if defined(TEST_COMPILER_C1XX)
-# define TEST_WORKAROUND_C1XX_BROKEN_NULLPTR_CONVERSION_OPERATOR
-# define TEST_WORKAROUND_C1XX_BROKEN_IS_TRIVIALLY_COPYABLE
Do you need to go update
CaseyCarter created this revision.
VSO#391542 "Types can't be convertible to nullptr_t," which will be fixed in
the next release of Visual C++.
Also put internal bug numbers on the workarounds in test_workarounds.h for ease
of correlation.
https://reviews.llvm.org/D33290
Files:
test/suppor
