fhahn updated this revision to Diff 101687.
fhahn added a comment.
rebased
https://reviews.llvm.org/D33448
Files:
lib/Basic/Targets.cpp
test/CodeGen/arm-long-calls.c
test/CodeGen/arm-no-movt.c
test/CodeGen/arm-target-features.c
test/CodeGen/arm-thumb-mode-target-feature.c
Index: test
fhahn added a comment.
I've discovered another problem while doing an ARM bootstrap build with mixed
ARM/Thumb codegen. With https://reviews.llvm.org/D33898 , the bootstrap build
with mixed ARM/Thumb code works properly. After that's in I'll finally commit
this patch.
https://reviews.llvm.org
echristo added a comment.
In https://reviews.llvm.org/D33448#765749, @fhahn wrote:
> I'll hold off merging this patch until https://reviews.llvm.org/D33436 lands,
> which fixes a problem with mixed ARM/Thumb codegen
OK. Commit at will :)
-eric
https://reviews.llvm.org/D33448
fhahn added a comment.
I'll hold off merging this patch until https://reviews.llvm.org/D33436 lands,
which fixes a problem with mixed ARM/Thumb codegen
https://reviews.llvm.org/D33448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
fhahn updated this revision to Diff 100371.
fhahn added a comment.
Updated the comment, thanks for the reviewing this patch!
https://reviews.llvm.org/D33448
Files:
lib/Basic/Targets.cpp
test/CodeGen/arm-long-calls.c
test/CodeGen/arm-no-movt.c
test/CodeGen/arm-target-features.c
test/Co
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
One minor nit and LGTM.
Thanks!
-eric
Comment at: lib/Basic/Targets.cpp:5353
+// enable or disable thumb-mode per function
+if (isThumb())
Mi
fhahn added a comment.
@echristo lib/Basic/Targets.cpp is indeed a much better place to add thumb-mode
to the target features, thanks for pointing me in the right direction!
https://reviews.llvm.org/D33448
___
cfe-commits mailing list
cfe-commits@l
fhahn updated this revision to Diff 100222.
fhahn retitled this revision from "[CodeGen] Add thumb-mode to function
target-features for arm/thumb triples." to "[CodeGen] Add thumb-mode to
target-features for arm/thumb triples.".
fhahn edited the summary of this revision.
fhahn added a comment.
M
