[PATCH] D33623: Make the parser close parens for you on EOF

2017-05-30 Thread Matt Kulukundis via Phabricator via cfe-commits
fowles abandoned this revision. fowles added a comment. Switching to https://reviews.llvm.org/D33679 for sbenza's suggestion https://reviews.llvm.org/D33623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D33623: Make the parser close parens for you on EOF

2017-05-30 Thread Samuel Benzaquen via Phabricator via cfe-commits
sbenza added a comment. Do we want this change in the parser itself? or in clang-query? clang-query could be helpful enough to add parens when it detect an `ET_ParserNoCloseParen` error, without changing the language here. https://reviews.llvm.org/D33623 _

[PATCH] D33623: Make the parser close parens for you on EOF

2017-05-30 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. Sam knows this stuff much better. https://reviews.llvm.org/D33623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33623: Make the parser close parens for you on EOF

2017-05-27 Thread Matt Kulukundis via Phabricator via cfe-commits
fowles created this revision. Herald added a subscriber: klimek. Makes the parser for clang-query auto close all open parens on EOF https://reviews.llvm.org/D33623 Files: lib/ASTMatchers/Dynamic/Parser.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp Index: unittests/ASTMatchers/Dynamic/P