[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-07-17 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. Committed in r308242. Thanks Dominik! Repository: rL LLVM https://reviews.llvm.org/D33645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-07-17 Thread Devin Coughlin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308242: [analyzer] Add missing documentation for static analyzer checkers (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D33645?vs=106184&id=106989#toc Repository: rL LLVM

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-07-12 Thread Dominik Szabó via Phabricator via cfe-commits
szdominik added a comment. In https://reviews.llvm.org/D33645#806852, @dcoughlin wrote: > Do you have commit access, or do you need someone to commit it for you? Thank you. I don't have, I'm quite new at this project. :) https://reviews.llvm.org/D33645 _

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-07-12 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Do you have commit access, or do you need someone to commit it for you? https://reviews.llvm.org/D33645 ___ cfe-commits mail

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-07-12 Thread Dominik Szabó via Phabricator via cfe-commits
szdominik updated this revision to Diff 106184. szdominik marked 9 inline comments as done. szdominik added a comment. Update with more idiomatic examples (from @dcoughlin). https://reviews.llvm.org/D33645 Files: www/analyzer/alpha_checks.html www/analyzer/available_checks.html www/analyz

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-07-12 Thread Dominik Szabó via Phabricator via cfe-commits
szdominik added a comment. In https://reviews.llvm.org/D33645#805920, @dcoughlin wrote: > Who is the target of this documentation? Is it developers of the analyzer or > is it end users of the analyzer? If it is end users, it is unfortunate that > we've been just grabbing examples from the regre

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-07-11 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. Thanks for the patch. It is really great to see these documented! Who is the target of this documentation? Is it developers of the analyzer or is it end users of the analyzer? If it is end users, it is unfortunate that we've been just grabbing examples from the regres

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-07-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I think next time we should add examples of warning messages here - not just "//warn" but how they literally may look - so that people were able to find this page, and not doxygen/github source code, when they google up their warning messages. https://reviews.llvm.org/D33

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-06-21 Thread Dominik Szabó via Phabricator via cfe-commits
szdominik updated this revision to Diff 103378. szdominik marked 3 inline comments as done. szdominik added a comment. Fixed alpha.core.CallAndMessageUnInitRefArg. https://reviews.llvm.org/D33645 Files: www/analyzer/alpha_checks.html www/analyzer/available_checks.html www/analyzer/implici

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-06-16 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added inline comments. Comment at: www/analyzer/alpha_checks.html:91 +(C, C++) +Check for logical errors for function calls and Objective-C message +expressions (e.g., uninitialized arguments, null function pointers, szdominik wrote: > zaks.anna wrote

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-06-15 Thread Dominik Szabó via Phabricator via cfe-commits
szdominik marked 3 inline comments as done. szdominik added inline comments. Comment at: www/analyzer/alpha_checks.html:91 +(C, C++) +Check for logical errors for function calls and Objective-C message +expressions (e.g., uninitialized arguments, null function pointers, ---

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-06-15 Thread Dominik Szabó via Phabricator via cfe-commits
szdominik updated this revision to Diff 102650. szdominik added a comment. Delete modeling checkers (unix.StdCLibraryFunctions, cplusplus.SelfAssignment). Delete unix.MallocWithAnnotations. https://reviews.llvm.org/D33645 Files: www/analyzer/alpha_checks.html www/analyzer/available_checks.h

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-06-14 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. Great cleanup! Some comments below. Comment at: www/analyzer/alpha_checks.html:91 +(C, C++) +Check for logical errors for function calls and Objective-C message +expressions (e.g., uninitialized arguments, null function pointers, fo

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-05-29 Thread Dominik Szabó via Phabricator via cfe-commits
szdominik created this revision. Some checks did not have documentation in the www/analyzer/ folder, and also some alpha checks became non-alpha. https://reviews.llvm.org/D33645 Files: www/analyzer/alpha_checks.html www/analyzer/available_checks.html www/analyzer/implicit_checks.html In