This revision was automatically updated to reflect the committed changes.
Closed by commit rL305711: CodeGen: Cast temporary variable to proper address
space (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D33706?vs=101227&id=103070#toc
Repository:
rL LLVM
https://re
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D33706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
yaxunl updated this revision to Diff 101227.
yaxunl added a comment.
Fix a comment.
https://reviews.llvm.org/D33706
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/address-space.c
test/CodeGen/default-address-spa
rjmccall added a comment.
Thanks. One tweak and then LGTM.
Comment at: lib/CodeGen/CodeGenFunction.h:1937
+ /// to the stack.
+
+ /// Because the address of a temporary is often exposed to the program in
This line should have ///.
https://reviews.llvm.org/
yaxunl updated this revision to Diff 101221.
yaxunl marked 7 inline comments as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D33706
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
test/Code
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3805
+Address Addr =
+CreateMemTemp(I->Ty, ArgInfo.getIndirectAlign(), "tmp", false);
IRCallArgs[FirstIRArg] = Addr.getPointer();
How about "indirect-arg-temp" as the
yaxunl updated this revision to Diff 101070.
yaxunl marked 2 inline comments as done.
yaxunl retitled this revision from "[AMDGPU] Fix address space for global and
temporary variables in C++" to "CodeGen: Cast temporary variable to proper
address space".
yaxunl edited the summary of this revision
