EricWF abandoned this revision.
EricWF added a comment.
In https://reviews.llvm.org/D33741#769421, @CaseyCarter wrote:
> In https://reviews.llvm.org/D33741#769381, @EricWF wrote:
>
> > In https://reviews.llvm.org/D33741#769371, @STL_MSFT wrote:
> >
> > > I haven't seen min/max test failures, prob
CaseyCarter added a comment.
In https://reviews.llvm.org/D33741#769381, @EricWF wrote:
> In https://reviews.llvm.org/D33741#769371, @STL_MSFT wrote:
>
> > I haven't seen min/max test failures, probably because our CRT/STL headers
> > never drag in Windows.h.
>
>
> Ah, that makes sense. Libc++ cu
EricWF added a comment.
In https://reviews.llvm.org/D33741#769371, @STL_MSFT wrote:
> I haven't seen min/max test failures, probably because our CRT/STL headers
> never drag in Windows.h.
Ah, that makes sense. Libc++ currently does although the plan is to fix that
eventually. :-S
> I have no
STL_MSFT added a comment.
I haven't seen min/max test failures, probably because our CRT/STL headers
never drag in Windows.h.
I have no objection to undeffing min/max although I wouldn't do this myself (it
creates order dependencies which I think are totally evil).
https://reviews.llvm.org/D3
EricWF created this revision.
After changing libc++ to push/pop the min/max macros on Windows we have a bunch
of new test failures, caused by tests using min/max. I would like to use
test_macros.h to undefine it.
Would this work for you? How have you been dealing with these failures?
https:/
