[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

alexfh added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:38-40 +Message = "'extern' keyword has no effect"; + } else { +Message = "redundant 'extern' keyword"; These messages alone will be quite confusing unless the user

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

alexfh added a comment. In D33841#1589212 , @koldaniel wrote: > Hi, do you have any additional comments? Could you mark "Done" the comments you've addressed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

koldaniel added a comment. Hi, do you have any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

koldaniel updated this revision to Diff 206190. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33841 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantExternCheck.cpp c

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

koldaniel marked an inline comment as done. koldaniel added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:43-44 + + if (FD->getBeginLoc().isMacroID()) +return; + lebedev.ri wrote: > koldaniel wrote: > > lebedev.ri wrote: > > >

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

lebedev.ri added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:43-44 + + if (FD->getBeginLoc().isMacroID()) +return; + koldaniel wrote: > lebedev.ri wrote: > > Similarly, do this in `registerMatchers()` > Could you please help

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

koldaniel marked an inline comment as done. koldaniel added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:30 + + if (FD->getStorageClass() != SC_Extern) +return; lebedev.ri wrote: > Can you do that in `registerMatchers()`? The

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

lebedev.ri added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:30 + + if (FD->getStorageClass() != SC_Extern) +return; Can you do that in `registerMatchers()`? Comment at: clang-tidy/readability/RedundantExte