joey closed this revision.
joey added a comment.
I committed all the parts separately: r309567 (with r309571 to fix a test),
r309678 and r310477.
https://reviews.llvm.org/D33945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
https://reviews.llvm.org/D33945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
Thanks!
Overall the patch looks good, but I would suggest splitting it into three
commits (as they seems to be independent):
1. [OpenCL] Check that cl_khr_subgroups pragma is enabled if
joey updated this revision to Diff 108452.
joey added a comment.
Updated all the comments you made and rebased.
Sorry for the long delay.
https://reviews.llvm.org/D33945
Files:
CodeGen/CGBuiltin.cpp
CodeGenOpenCL/cl20-device-side-enqueue.cl
CodeGenOpenCL/pipe_builtin.cl
bader requested changes to this revision.
bader added a comment.
This revision now requires changes to proceed.
Please, split this patch into two parts:
1. Improve diagnostics on extension enabling.
2. Add missing `sub_group_*` built-in functions.
Comment at:
joey created this revision.
Herald added subscribers: Anastasia, yaxunl.
This adds get_kernel_max_sub_group_size_for_ndrange and
get_kernel_sub_group_count_for_ndrange.
Note this also changes err_opencl_requires_extension to print the name of the
function that the diagnostic is warning about.
