This revision was automatically updated to reflect the committed changes.
Closed by commit rL305392: Be more strict when checking the -flto option value
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34055?vs=102551&id=102555#toc
Repository:
rL LLVM
https://revi
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix!
https://reviews.llvm.org/D34055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
yamaguchi updated this revision to Diff 102551.
yamaguchi added a comment.
Herald added a subscriber: eraman.
Update patch. Add testcase and check if argument is valid or not.
https://reviews.llvm.org/D34055
Files:
clang/lib/Frontend/CompilerInvocation.cpp
clang/test/CodeGen/thinlto-backend
tejohnson added a comment.
In https://reviews.llvm.org/D34055#777005, @yamaguchi wrote:
> I think we don't need additional testcase, because this is non-functional
> change. Driver.cpp will emit error if value was not "thin" nor "full". This
> testcase is at clang/test/CodeGen/thinlto-backend-o
yamaguchi updated this revision to Diff 102051.
yamaguchi added a comment.
I think we don't need additional testcase, because this is non-functional
change. Driver.cpp will emit error if value was not "thin" nor "full". This
testcase is at clang/test/CodeGen/thinlto-backend-option.ll.
https://
tejohnson added a comment.
Make sure you add cfe-commits to the mailing list for clang changes (and
llvm-commits for llvm changes, I accidentally added that one first and then
fixed it), since all patches should go to the full mailing list.
This fix looks correct to me. Please add a test case t
