This revision was automatically updated to reflect the committed changes.
Closed by commit rL307130: [clang-tidy] Add "MakeSmartPtrFunction" option to
modernize-make-shared/unique… (authored by hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D34206
Files:
hokein updated this revision to Diff 105190.
hokein marked 2 inline comments as done.
hokein added a comment.
Fix small nits.
https://reviews.llvm.org/D34206
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits.
Comment at: test/clang-tidy/modernize-make-shared-header.cpp:9
+// RUN: -- -std=c++11 \
+// RUN: -I%S/Inputs/modernize-smart-ptr
+
hokein added inline comments.
Comment at: test/clang-tidy/modernize-make-shared-header.cpp:1
+// RUN: cp %S/Inputs/modernize-smart-ptr/shared_ptr.h %T/shared_ptr.h
+// RUN: %check_clang_tidy %s modernize-make-shared %t -- \
alexfh wrote:
> Maybe just add
hokein updated this revision to Diff 104922.
hokein marked 2 inline comments as done.
hokein added a comment.
Herald added a subscriber: JDevlieghere.
Rebase and address review comments.
https://reviews.llvm.org/D34206
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.h:28
MakeSmartPtrCheck(StringRef Name, ClangTidyContext *Context,
-std::string
hokein added a comment.
In https://reviews.llvm.org/D34206#790406, @alexfh wrote:
> Ping me once you're done fixing the bugs.
The bugs are fixed. The patch is ready for review ;)
https://reviews.llvm.org/D34206
___
cfe-commits mailing list
hokein added a comment.
In https://reviews.llvm.org/D34206#790406, @alexfh wrote:
> In https://reviews.llvm.org/D34206#783673, @hokein wrote:
>
> > In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote:
> >
> > > It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for
>
alexfh added a comment.
In https://reviews.llvm.org/D34206#783673, @hokein wrote:
> In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote:
>
> > It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for
> > llvm::make_unique.
>
>
> +1. See https://reviews.llvm.org/D34334,
hokein added a comment.
In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote:
> It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for
> llvm::make_unique.
+1. See https://reviews.llvm.org/D34334, https://reviews.llvm.org/D34333. And
found a few bugs in the check,
hokein updated this revision to Diff 102833.
hokein added a comment.
More improvements.
https://reviews.llvm.org/D34206
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
docs/clang-tidy/checks/modernize-make-shared.rst
Eugene.Zelenko added a comment.
It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for
llvm::make_unique.
https://reviews.llvm.org/D34206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein created this revision.
Herald added a subscriber: xazax.hun.
https://reviews.llvm.org/D34206
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
docs/clang-tidy/checks/modernize-make-shared.rst
docs/clang-tidy/checks/modernize-make-unique.rst
13 matches
Mail list logo