phosek created this revision.
When -no-canonical-prefixes option is used and argv0 contains only
a program name, we need to do a PATH lookup to get an executable path,
otherwise the return value won't be a valid path and any subsequent
uses of it (e.g. invoking -cc1) will fail with an error.
Rep
hans added a comment.
Thanks!
Please add to the description that this is for PR9576.
Comment at: tools/driver/driver.cpp:58
+SmallString<128> ExecutablePath(Argv0);
+// Do a PATH lookup, if there are no directory components.
+if (llvm::sys::path::filename(Executabl
phosek added inline comments.
Comment at: tools/driver/driver.cpp:58
+SmallString<128> ExecutablePath(Argv0);
+// Do a PATH lookup, if there are no directory components.
+if (llvm::sys::path::filename(ExecutablePath) == ExecutablePath)
hans wrote:
> W
phosek updated this revision to Diff 102881.
phosek marked an inline comment as done.
phosek edited the summary of this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D34290
Files:
tools/driver/driver.cpp
Index: tools/driver/driver.cpp
==
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D34290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305600: [Driver] Do a PATH lookup if needed when using
-no-canonical-prefixes (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D34290?vs=102881&id=102894#toc
Repository:
rL LLV
