bruno added inline comments.
Comment at: lib/AST/ASTContext.cpp:8551
+ break;
+}
case 'W':
bruno wrote:
> rnk wrote:
> > majnemer wrote:
> > > bruno wrote:
> > > > bruno wrote:
> > > > > rnk wrote:
> > > > > > compnerd wrote:
> > > > > > > I agree
rnk added inline comments.
Comment at: lib/AST/ASTContext.cpp:8551
+ break;
+}
case 'W':
majnemer wrote:
> bruno wrote:
> > bruno wrote:
> > > rnk wrote:
> > > > compnerd wrote:
> > > > > I agree with @majnemer. Why not base this on the Int64Type?
bruno added inline comments.
Comment at: lib/AST/ASTContext.cpp:8551
+ break;
+}
case 'W':
majnemer wrote:
> bruno wrote:
> > bruno wrote:
> > > rnk wrote:
> > > > compnerd wrote:
> > > > > I agree with @majnemer. Why not base this on the
majnemer added inline comments.
Comment at: lib/AST/ASTContext.cpp:8551
+ break;
+}
case 'W':
bruno wrote:
> bruno wrote:
> > rnk wrote:
> > > compnerd wrote:
> > > > I agree with @majnemer. Why not base this on the Int64Type?
> > > I'd suggest
bruno added inline comments.
Comment at: include/clang/Basic/Builtins.def:55
// W -> int64_t
+// l -> 'int' if builtin is a MS extensions and the target is Darwin/LP64.
+// Defaults to 'L' otherwise.
rnk wrote:
> majnemer wrote:
> > Why not just
rnk added inline comments.
Comment at: include/clang/Basic/Builtins.def:55
// W -> int64_t
+// l -> 'int' if builtin is a MS extensions and the target is Darwin/LP64.
+// Defaults to 'L' otherwise.
majnemer wrote:
> Why not just LP64? Seems
