SjoerdMeijer created this revision.
Herald added subscribers: aheejin, dschuff, jfb.
This adds the _Float16 preprocessor macro definitions.
https://reviews.llvm.org/D34695
Files:
lib/Frontend/InitPreprocessor.cpp
lib/Headers/float.h
test/Preprocessor/init.c
Index: test/Preprocessor/init.
rogfer01 added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
My understanding is that, given that we support TS18661-2 by default, this
macro should be predefined by
scanon added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
rogfer01 wrote:
> My understanding is that, given that we support TS18661-2 by default, this
> macro shoul
rogfer01 added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
scanon wrote:
> rogfer01 wrote:
> > My understanding is that, given that we support TS18661-2 by default,
scanon added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
rogfer01 wrote:
> scanon wrote:
> > rogfer01 wrote:
> > > My understanding is that, given that we support T
SjoerdMeijer added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
scanon wrote:
> rogfer01 wrote:
> > scanon wrote:
> > > rogfer01 wrote:
> > > > My understanding is t
SjoerdMeijer updated this revision to Diff 114998.
SjoerdMeijer added a comment.
Fixed the typos, and added tests.
https://reviews.llvm.org/D34695
Files:
lib/Frontend/InitPreprocessor.cpp
lib/Headers/float.h
test/Headers/float16.c
test/Preprocessor/init.c
Index: test/Preprocessor/init.
rogfer01 accepted this revision.
rogfer01 added a subscriber: rsmith.
rogfer01 added a comment.
This revision is now accepted and ready to land.
This LGTM, but wait a couple of days before comitting in case @rsmith or
@scanon (or others!) have further comments.
https://reviews.llvm.org/D34695
scanon accepted this revision.
scanon added a comment.
LGTM as well.
https://reviews.llvm.org/D34695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer added a comment.
many thanks for reviewing and your help.
https://reviews.llvm.org/D34695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313152: This adds the _Float16 preprocessor macro
definitions. (authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D34695?vs=114998&id=115050#toc
Repository:
rL LLVM
https:
11 matches
Mail list logo