This revision was automatically updated to reflect the committed changes.
Closed by commit rL306672: [clang-format] Fix parsing of msg{field}-style proto
options (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D34749?vs=104410&id=104632#toc
Repository:
rL LLVM
http
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D34749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
krasimir added a comment.
I think this is ready for a review.
https://reviews.llvm.org/D34749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir updated this revision to Diff 104410.
krasimir added a comment.
- Add a msg-style test too
https://reviews.llvm.org/D34749
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
Index: unittests/Format/FormatTestProto.cpp
===
krasimir created this revision.
Herald added a subscriber: klimek.
This patch makes the `{` in `msg_field{field: OK}` in a proto option scope be
treated as an assignment operator. Previosly the added test case was formatted
as:
option (MyProto.options) = {
field_a: OK
field_b{field_c: O
