[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

2017-07-05 Thread David L. Jones via Phabricator via cfe-commits
dlj added a comment. In https://reviews.llvm.org/D34853#798699, @andrewng wrote: > Hi, > > I believe that this "build mode" is intended for the Visual Studio MSVC > build. This build is special in that it can produce builds for multiple > configurations, e.g. Debug, Release & RelWithDebInfo, wi

[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

2017-07-05 Thread Andrew Ng via Phabricator via cfe-commits
andrewng added a comment. Hi, I believe that this "build mode" is intended for the Visual Studio MSVC build. This build is special in that it can produce builds for multiple configurations, e.g. Debug, Release & RelWithDebInfo, within the same top level build output directory. It is this confi

[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

2017-06-29 Thread David L. Jones via Phabricator via cfe-commits
dlj created this revision. dlj added projects: lld, clang. Herald added subscribers: mehdi_amini, sanjoy. The GoogleTest lit format accepts two parameters to its constructor: a subdirectory to find test binaries, and a required suffix for the test filenames. Typically, the config should look lik