[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

This revision was automatically updated to reflect the committed changes. Closed by commit rL308899: [CodeGen] Propagate dllexport to thunks (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D34972 Files: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

smeenai updated this revision to Diff 107795. smeenai edited the summary of this revision. smeenai added a comment. Add comment https://reviews.llvm.org/D34972 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/dllexport-vtable-thunks.cpp Index:

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

majnemer added a comment. OK, so we are exporting the thunks so that the linker will generate import thunks for the thunks. I think that we should have a comment to that effect near the code you added. https://reviews.llvm.org/D34972 ___

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

smeenai added a comment. Ping. I updated the description based on the email discussion with @majnemer. https://reviews.llvm.org/D34972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

sts.llvm.org" <cfe-commits@lists.llvm.org>, "ztur...@google.com" <ztur...@google.com> Subject: Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks If the thinks are not imported, why would it make sense to export them? Maybe devirtualization could trigger this? On

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

a22767368a5b...@reviews.llvm.org>, "r...@google.com" > <r...@google.com> > Cc: "ztur...@google.com" <ztur...@google.com>, "cfe-commits@lists.llvm.org" > <cfe-commits@lists.llvm.org> > Subject: Re: [PATCH] D34972: [CodeGen] Propagate

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

+d34972+public+8a22767368a5b...@reviews.llvm.org>, "r...@google.com" <r...@google.com> Cc: "ztur...@google.com" <ztur...@google.com>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> Subject: Re: [PATCH] D34972: [CodeGen] Propagate dllexport t

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

What about the import side? On Mon, Jul 3, 2017 at 10:37 PM Shoaib Meenai via Phabricator via cfe-commits wrote: > smeenai created this revision. > > Under Windows Itanium, we need to export virtual and non-virtual thunks > if the functions being thunked are

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

smeenai created this revision. Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These thunks would previously inherit their dllexport attribute from the declaration, but r298330 changed declarations to not have dllexport