This revision was automatically updated to reflect the committed changes.
Closed by commit rL307933: [AArch64] Produce the right kind of va_arg for
windows (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D35008?vs=105392&id=106471#toc
Repository:
rL LLVM
https://re
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/CodeGen/TargetInfo.cpp:8463
Kind = AArch64ABIInfo::DarwinPCS;
+else if (Triple.getOS() == llvm::Triple::Win32)
+ Kind = AArch64ABIInfo::Win64;
mstorsjo added a comment.
Ping - the dependency, https://reviews.llvm.org/D35006, has now been committed.
https://reviews.llvm.org/D35008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
mstorsjo updated this revision to Diff 105392.
mstorsjo marked an inline comment as done.
mstorsjo added a comment.
Herald added a subscriber: javed.absar.
Added a testcase, using a different Kind instead of adding a separate bool.
https://reviews.llvm.org/D35008
Files:
lib/CodeGen/TargetInfo
mstorsjo marked an inline comment as done.
mstorsjo added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:4769
DarwinPCS
};
efriedma wrote:
> Can we extend ABIKind rather than adding a separate boolean?
Sure. I was afraid there was a lot of chec
efriedma added a comment.
Needs a testcase (to check the emitted IR).
Comment at: lib/CodeGen/TargetInfo.cpp:4769
DarwinPCS
};
Can we extend ABIKind rather than adding a separate boolean?
https://reviews.llvm.org/D35008
__
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, rengolin, aemerson.
On windows on arm64, the va_list is a plain pointer.
https://reviews.llvm.org/D35008
Files:
lib/CodeGen/TargetInfo.cpp
Index: lib/CodeGen/TargetInfo.cpp
=
