This revision was automatically updated to reflect the committed changes.
Closed by commit rL308662: [clang] Fix handling of "%zd" in scanf (authored by
alexshap).
Changed prior to commit:
https://reviews.llvm.org/D35652?vs=107569=107574#toc
Repository:
rL LLVM
alexshap updated this revision to Diff 107569.
alexshap added a comment.
Address comments
Repository:
rL LLVM
https://reviews.llvm.org/D35652
Files:
lib/Analysis/ScanfFormatString.cpp
test/Sema/format-strings-fixit-ssize_t.c
test/Sema/format-strings-scanf.c
Index:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a small testing nit.
Comment at: test/Sema/format-strings-scanf.c:1
-// RUN: %clang_cc1 -fsyntax-only -verify -Wformat-nonliteral %s
+// RUN:
alexshap added inline comments.
Comment at: test/Sema/format-strings-fixit-ssize_t.c:4
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -std=c99 -fsyntax-only
-pedantic -Wall -Werror %t
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -std=c99 -E -o - %t |
FileCheck %s
alexshap created this revision.
This is a follow-up for https://reviews.llvm.org/D35427
ScanfFormatString.cpp has the same issue (incorrect handling of
the specifiers for ssize_t) and this diff fixes it and adds tests.
Test plan: make check-all
Repository:
rL LLVM