This revision was automatically updated to reflect the committed changes.
Closed by commit rL311344: [StaticAnalyzer] Handle LoopExit CFGElement in the
analyzer (authored by szepet).
Changed prior to commit:
https://reviews.llvm.org/D35670?vs=110981&id=111993#toc
Repository:
rL LLVM
https:/
dcoughlin added a comment.
Also, please mention in the commit message that tests will be added in a
following commit.
https://reviews.llvm.org/D35670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me! (Please expand the comment, though.)
Comment at: include/clang/Analysis/ProgramPoint.h:658
+class LoopExit : public ProgramPoint {
+public:
szepet added inline comments.
Comment at: include/clang/Analysis/ProgramPoint.h:658
+class LoopExit : public ProgramPoint {
+public:
dcoughlin wrote:
> Can you add a comment explaining what meaning of this program point is.
Can you help me with that? I am not s
szepet updated this revision to Diff 110981.
szepet marked an inline comment as done.
szepet added a comment.
Updates based on comments.
https://reviews.llvm.org/D35670
Files:
include/clang/Analysis/ProgramPoint.h
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnal
dcoughlin added inline comments.
Comment at: include/clang/Analysis/ProgramPoint.h:658
+class LoopExit : public ProgramPoint {
+public:
Can you add a comment explaining what meaning of this program point is.
Comment at: lib/StaticAnalyzer/Cor
szepet updated this revision to Diff 108312.
szepet added a subscriber: cfe-commits.
szepet added a comment.
Accidentally left debug print removed.
https://reviews.llvm.org/D35670
Files:
include/clang/Analysis/ProgramPoint.h
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib
