[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308684: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D35683 Files: cfe/trunk/lib/Format/BreakableToken.cpp

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 107593. krasimir marked an inline comment as done. krasimir added a comment. - Add negative tests https://reviews.llvm.org/D35683 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Martin Probst via Phabricator via cfe-commits
mprobst accepted this revision. mprobst added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/BreakableToken.cpp:436 + if (Style.Language == FormatStyle::LK_JavaScript) { +if ((Lines[0] == "*" || Lines[0].startswith("* ")) && Lines.si

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked 2 inline comments as done. krasimir added inline comments. Comment at: lib/Format/BreakableToken.cpp:435 + // Detect a multiline jsdoc comment and set DelimitersOnNewline in that case. + if (Style.Language == FormatStyle::LK_JavaScript) { +if ((Lines[0] == "

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 107539. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D35683 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Fo

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Martin Probst via Phabricator via cfe-commits
mprobst added inline comments. Comment at: lib/Format/BreakableToken.cpp:435 + // Detect a multiline jsdoc comment and set DelimitersOnNewline in that case. + if (Style.Language == FormatStyle::LK_JavaScript) { +if ((Lines[0] == "*" || Lines[0].startswith("* ")) && Lines.si