[PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-09-29 Thread Paul Robinson via Phabricator via cfe-commits
probinson abandoned this revision. probinson added a comment. Abandoning. This change is irrelevant to the SCE debugger, and while I believe it could be made more complete and better reflect the original source (which is what the DWARF spec says names should be), I do not have time to pursue

Re: [PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-07-21 Thread David Blaikie via cfe-commits
On Fri, Jul 21, 2017 at 12:57 PM David Blaikie wrote: > On Fri, Jul 21, 2017 at 11:34 AM David Majnemer via Phabricator < > revi...@reviews.llvm.org> wrote: > >> majnemer added a comment. >> >> This might be a silly question but why not do this by default? >> > > I'd hazard a

Re: [PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-07-21 Thread David Blaikie via cfe-commits
On Fri, Jul 21, 2017 at 11:34 AM David Majnemer via Phabricator < revi...@reviews.llvm.org> wrote: > majnemer added a comment. > > This might be a silly question but why not do this by default? > I'd hazard a guess that GDB wouldn't cope well with this (in terms of identifying templates as the

[PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-07-21 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. This might be a silly question but why not do this by default? https://reviews.llvm.org/D35715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-07-21 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: include/clang/AST/TemplateBase.h:109-111 +// This is the type that most closely resembles what is in the source. +// At the moment it is retaining typedefs, but not decltype or typeof. +uintptr_t DisplayType;

[PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-07-20 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: include/clang/AST/PrettyPrinter.h:205 + + /// \brief When true, print template type arguments without removing typedefs. + unsigned PrintTemplateTypesWithTypedefs : 1; `\brief` is no longer necessary and just makes

[PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-07-20 Thread Paul Robinson via Phabricator via cfe-commits
probinson created this revision. If a template instantiation uses a typedef'd name as a template parameter, this is usually resolved to its underlying type when we generate the name of the instance in the debug info. PS4 prefers to see the original parameter as in the source. Define an option