klimek added a comment.
In https://reviews.llvm.org/D35743#841197, @chh wrote:
> Daniel, Manuel, I will take over this CL since Yan has finished his
> internship at Google.,
> Yan's latest patch to tryToParseLambda looks acceptable to me.
> I think it should take care of new kw_auto in additio
chh added a comment.
ping.
https://reviews.llvm.org/D35743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh added a comment.
Daniel, Manuel, I will take over this CL since Yan has finished his internship
at Google.,
Yan's latest patch to tryToParseLambda looks acceptable to me.
I think it should take care of new kw_auto in additional to kw_new, ke_delete,
etc.
Could you suggest if there is any be
yawanng updated this revision to Diff 110640.
yawanng added a comment.
Show full context.
https://reviews.llvm.org/D35743
Files:
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/For
djasper added a comment.
Generally, please upload patches with full context to phabricator. (or use arc)
I think this approach is a bit inside out. We are in a codepath where we try to
find a lambda introducer and we the look one or two tokens back to see that we
aren't as we have seen "auto".
yawanng updated this revision to Diff 109222.
yawanng added a comment.
Move tests to unitest and fix a bug.
https://reviews.llvm.org/D35743
Files:
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index: un
djasper added a comment.
Please add all the tests into unittests/Format/FormatTest.cpp instead. We use
FileCheck-based tests only to verify the behavior of the clang-format binary
itself.
https://reviews.llvm.org/D35743
___
cfe-commits mailing lis
yawanng added a comment.
Ping.
https://reviews.llvm.org/D35743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yawanng created this revision.
yawanng added a project: clang-tools-extra.
Herald added a subscriber: klimek.
Add handling for Structured binding declaration in C++17 in clang-format. For
example:
auto [x,y] = a;
auto &[xr, yr] = a;
auto &&[xrr, yrr] = a;
https://reviews.llvm.org/D35743
File
